[lkml]   [2022]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Fw:Re: [PATCH] fs: nilfs2: fix memory leak in nilfs sysfs create device group
Hi Ryusuke,

On 3/12/22 18:11, Ryusuke Konishi wrote:
>> In case of nilfs_attach_log_writer() error code jumps to
>> failed_checkpoint label and calls destroy_nilfs() which should call
>> nilfs_sysfs_delete_device_group().
> nilfs_sysfs_delete_device_group() is called in destroy_nilfs()
> if nilfs->ns_flags has THE_NILFS_INIT flag -- nilfs_init() inline
> function tests this flag.
> The flag is set after init_nilfs() succeeded at the beginning of
> nilfs_fill_super() because the set_nilfs_init() inline in init_nilfs() sets it.
> So, nilfs_sysfs_delete_group() seems to be called in case of
> the above failure. Am I missing something?

Yeah, that's what I mean :) I can't see how reported issue is possible
with current code.

Sorry for not being clear

With regards,
Pavel Skripkin

 \ /
  Last update: 2022-03-12 16:16    [W:0.114 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site