lkml.org 
[lkml]   [2022]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties
From
Date
On 3/11/22 4:33 PM, Krzysztof Kozlowski wrote:
> On 11/03/2022 15:07, Vladimir Zapolskiy wrote:
>> On 3/11/22 3:38 PM, Arnd Bergmann wrote:
>>> On Fri, Mar 11, 2022 at 2:20 PM Vladimir Zapolskiy <vz@mleia.com> wrote:
>>>>
>>>> On 3/11/22 11:38 AM, Kuldeep Singh wrote:
>>>>> PL022 binding require two clocks to be defined but lpc platform doesn't
>>>>> comply with bindings and define only one clock i.e apb_pclk.
>>>>>
>>>>> Update spi clocks and clocks-names property by adding appropriate clock
>>>>> reference to make it compliant with bindings.
>>>>>
>>>>> CC: Vladimir Zapolskiy <vz@mleia.com>
>>>>> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
>>>>> ---
>>>>> v2:
>>>>> - New patch with similar changeset
>>>>> - Send to soc ML
>>>>>
>>>>> arch/arm/boot/dts/lpc32xx.dtsi | 8 ++++----
>>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
>>>>> index c87066d6c995..30958e02d5e2 100644
>>>>> --- a/arch/arm/boot/dts/lpc32xx.dtsi
>>>>> +++ b/arch/arm/boot/dts/lpc32xx.dtsi
>>>>> @@ -178,8 +178,8 @@ ssp0: spi@20084000 {
>>>>> compatible = "arm,pl022", "arm,primecell";
>>>>> reg = <0x20084000 0x1000>;
>>>>> interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
>>>>> - clocks = <&clk LPC32XX_CLK_SSP0>;
>>>>> - clock-names = "apb_pclk";
>>>>> + clocks = <&clk LPC32XX_CLK_SSP0>, <&clk LPC32XX_CLK_SSP0>;
>>>>> + clock-names = "sspclk", "apb_pclk";
>>>>
>>>> In fact I'm uncertain if it is the right change, could it happen that the commit
>>>> cc0f6e96c4fd ("spi: dt-bindings: Convert Arm pl022 to json-schema") sets a wrong
>>>> schema pattern?
>>>
>>> Good pointm this doesn't quite seem right: it is unlikely that the same clock
>>> is used for both the SPI bus and the APB bus.
>>>
>>>> Apparently just one clock is wanted on all observed platforms and cases, this
>>>> is implicitly confirmed by clock handling in the drivers/spi/spi-pl022.c :
>>>>
>>>> pl022->clk = devm_clk_get(&adev->dev, NULL);
>>>>
>>>> So, I would vote to fix the device tree bindings schema.
>
> Drivers do not describe the hardware. Bindings should not be modeled on
> drivers, but on actual hardware, so the example is not convincing.

My concern is that fixing the bindings can break the driver and all its users,
is it clear enough how it can happen in assumption that the driver uses just
one clock at the moment?

--
Best wishes,
Vladimir

\
 
 \ /
  Last update: 2022-03-11 23:49    [W:0.148 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site