lkml.org 
[lkml]   [2022]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 10/15] mm/page-flags: reuse PG_slab as PG_anon_exclusive for PageAnon() pages
On Fri, Mar 11, 2022 at 10:46 AM David Hildenbrand <david@redhat.com> wrote:
>
> - PG_has_hwpoisoned = PG_mappedtodisk,
> + PG_has_hwpoisoned = PG_waiters,

That makes me too nervous for words. PG_waiters is very subtle.

Not only is it magical in bit location ways (and the special
clear_bit_unlock_is_negative_byte() macro that *literally* exists only
for unlocking a page), it just ends up having fairly subtle semantics
with intentionally racy clearing etc.

Mixing that up with any hwpoison bits - that aren't used by any normal
mortals and thus get very little coverage - just sounds horribly
horribly wrong.

Linus

\
 
 \ /
  Last update: 2022-03-11 20:23    [W:0.393 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site