lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 05/11] PCI: Use driver_set_override() instead of open-coding
From
On 28/02/2022 21:06, Bjorn Helgaas wrote:
> On Sun, Feb 27, 2022 at 02:52:08PM +0100, Krzysztof Kozlowski wrote:
>> Use a helper for seting driver_override to reduce amount of duplicated
>> code. Make the driver_override field const char, because it is not
>> modified by the core and it matches other subsystems.
>
> s/seting/setting/
> or even better, s/for seting/to set/
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
>> - char *driver_override; /* Driver name to force a match */
>> + /*
>> + * Driver name to force a match.
>> + * Do not set directly, because core frees it.
>> + * Use driver_set_override() to set or clear it.
>
> Wrap this comment to fill 78 columns or so.

Thanks, I'll fix both.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-01 09:43    [W:0.154 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site