lkml.org 
[lkml]   [2022]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Hi Alexandru,

On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > + if (ret < 0)
> > + return ret;
> > +
> > + if (ret & MDIO_PMA_EXTABLE_BT1)
>
>
> This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> is expected to change is it? So i wounder if it should be read once
> and stored away?

What is the state of this patches? Will you be able to make requested
changes and send new version?

Regards,
Oleskij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

\
 
 \ /
  Last update: 2022-02-07 10:40    [W:1.144 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site