Messages in this thread Patch in this message |  | | From | Lino Sanfilippo <> | Subject | [PATCH v4 4/9] serial: sc16is7xx: remove redundant check in rs485_config | Date | Mon, 28 Feb 2022 03:39:23 +0100 |
| |
In uart_set_rs485_config() the serial core already ensures that only one of both options RTS on send or RTS after send is set.
So remove this check from the drivers rs485_config() function to avoid redundancy.
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de> --- drivers/tty/serial/sc16is7xx.c | 10 ---------- 1 file changed, 10 deletions(-)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index b7a2db9c03e2..b4e66a322a58 100644 --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -983,16 +983,6 @@ static int sc16is7xx_config_rs485(struct uart_port *port, struct sc16is7xx_one *one = to_sc16is7xx_one(port, port); if (rs485->flags & SER_RS485_ENABLED) { - bool rts_during_rx, rts_during_tx; - - rts_during_rx = rs485->flags & SER_RS485_RTS_AFTER_SEND; - rts_during_tx = rs485->flags & SER_RS485_RTS_ON_SEND; - - if (rts_during_rx == rts_during_tx) - dev_err(port->dev, - "unsupported RTS signalling on_send:%d after_send:%d - exactly one of RS485 RTS flags should be set\n", - rts_during_tx, rts_during_rx); - /* * RTS signal is handled by HW, it's timing can't be influenced. * However, it's sometimes useful to delay TX even without RTS -- 2.35.1
|  |