Messages in this thread |  | | Date | Sun, 27 Feb 2022 08:57:40 -0800 | Subject | Re: [PATCH -next] misc: rtsx: fix build for CONFIG_PM not set | From | Randy Dunlap <> |
| |
On 2/27/22 04:04, Arnd Bergmann wrote: > On Sat, Feb 26, 2022 at 11:24 PM Randy Dunlap <rdunlap@infradead.org> wrote: > >> --- >> drivers/misc/cardreader/rtsx_pcr.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> --- linux-next-20220225.orig/drivers/misc/cardreader/rtsx_pcr.c >> +++ linux-next-20220225/drivers/misc/cardreader/rtsx_pcr.c >> @@ -1054,6 +1054,7 @@ static int rtsx_pci_acquire_irq(struct r >> return 0; >> } >> >> +#ifdef CONFIG_PM >> static void rtsx_enable_aspm(struct rtsx_pcr *pcr) >> { >> if (pcr->ops->set_aspm) >> @@ -1085,6 +1086,7 @@ static void rtsx_pm_power_saving(struct >> { >> rtsx_comm_pm_power_saving(pcr); >> } >> +#endif > > Now that we have DEFINE_SIMPLE_DEV_PM_OPS() etc, I think we should > no longer add more __maybe_unused annotations or #ifdef CONFIG_PM checks > but just use the new macros for any new files or whenever a warning like > this shows up.
In this case it looks like DEFINE_RUNTIME_DEV_PM_OPS() is better. Using DEFINE_SIMPLE_DEV_PM_OPS() still produces build warnings/errors for unused functions. And I do see 4 drivers that are already using DEFINE_RUNTIME_DEV_PM_OPS().
Patch coming right up.
thanks. -- ~Randy
|  |