Messages in this thread |  | | Subject | Re: [PATCH 1/2] ALSA: core: remove initialise static variables to 0 | From | Joe Perches <> | Date | Sat, 26 Feb 2022 23:47:51 -0800 |
| |
On Sun, 2022-02-27 at 15:12 +0800, Meng Tang wrote: > Initializing the static variable to 0 causes the following error > when exec checkpatch: > > ERROR: do not initialise statics to 0 > FILE: sound/sound_core.c:142: > static int preclaim_oss = 0; > > Static variable does not need to be initialised to 0, because > compiler will initialise all uninitialised statics to 0. Thus, > remove the unneeded initializations. [] > diff --git a/sound/sound_core.c b/sound/sound_core.c [] > @@ -139,7 +139,7 @@ struct sound_unit > #ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM > static int preclaim_oss = 1; > #else > -static int preclaim_oss = 0; > +static int preclaim_oss; > #endif
Probably better without the #ifdef / #else / #endif as
static int preclaim_oss = IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM);
|  |