[lkml]   [2022]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS
Hi Shiyang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on xfs-linux/for-next]
[also build test ERROR on linux/master]
[cannot apply to hnaz-mm/master linus/master v5.17-rc5 next-20220225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: for-next
config: i386-randconfig-a003 (
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
git remote add linux-review
git fetch --no-tags linux-review Shiyang-Ruan/fsdax-introduce-fs-query-to-support-reflink/20220227-200849
git checkout 9f4bfbd2bae60e9f172e0b7332b2af32aa5baa87
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All errors (new ones prefixed by >>):

ld: fs/xfs/xfs_buf.o: in function `xfs_free_buftarg':
>> fs/xfs/xfs_buf.c:1897: undefined reference to `dax_unregister_holder'
ld: fs/xfs/xfs_notify_failure.o: in function `xfs_dax_notify_failure':
>> fs/xfs/xfs_notify_failure.c:187: undefined reference to `dax_holder'

vim +1897 fs/xfs/xfs_buf.c

1886 void
1887 xfs_free_buftarg(
1888 struct xfs_buftarg *btp)
1889 {
1890 unregister_shrinker(&btp->bt_shrinker);
1891 ASSERT(percpu_counter_sum(&btp->bt_io_count) == 0);
1892 percpu_counter_destroy(&btp->bt_io_count);
1893 list_lru_destroy(&btp->bt_lru);
1895 blkdev_issue_flush(btp->bt_bdev);
1896 if (btp->bt_daxdev)
> 1897 dax_unregister_holder(btp->bt_daxdev, btp->bt_mount);
1898 fs_put_dax(btp->bt_daxdev);
1900 kmem_free(btp);
1901 }

0-DAY CI Kernel Test Service, Intel Corporation

 \ /
  Last update: 2022-02-27 15:07    [W:0.263 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site