lkml.org 
[lkml]   [2022]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit

    On Wed, 9 Feb 2022 19:16:14 -0800, Jacob Pan
    <jacob.jun.pan@linux.intel.com> wrote:

    > Hi Fenghua,
    >
    > On Mon, 7 Feb 2022 15:02:48 -0800, Fenghua Yu <fenghua.yu@intel.com>
    > wrote:
    >
    > > @@ -1047,8 +1040,6 @@ struct iommu_sva *intel_svm_bind(struct device
    > > *dev, struct mm_struct *mm, void }
    > >
    > > sva = intel_svm_bind_mm(iommu, dev, mm, flags);
    > > - if (IS_ERR_OR_NULL(sva))
    > > - intel_svm_free_pasid(mm);
    > If bind fails, the PASID has no IOMMU nor CPU context. It should be safe
    > to free here.
    >
    Actually, here we cannot tell if the bind is the first of the mm so I think
    this is fine.

    Reviewed-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

    > Thanks,
    >
    > Jacob


    Thanks,

    Jacob

    \
     
     \ /
      Last update: 2022-02-10 19:46    [W:9.758 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site