lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 475/563] ext4: initialize err_blk before calling __ext4_get_inode_loc
    Date
    From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

    commit c27c29c6af4f3f4ce925a2111c256733c5a5b430 upstream.

    It is not guaranteed that __ext4_get_inode_loc will definitely set
    err_blk pointer when it returns EIO. To avoid using uninitialized
    variables, let's first set err_blk to 0.

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
    Link: https://lore.kernel.org/r/20211201163421.2631661-1-harshads@google.com
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/inode.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/ext4/inode.c
    +++ b/fs/ext4/inode.c
    @@ -4445,7 +4445,7 @@ has_buffer:
    static int __ext4_get_inode_loc_noinmem(struct inode *inode,
    struct ext4_iloc *iloc)
    {
    - ext4_fsblk_t err_blk;
    + ext4_fsblk_t err_blk = 0;
    int ret;

    ret = __ext4_get_inode_loc(inode->i_sb, inode->i_ino, iloc, 0,
    @@ -4460,7 +4460,7 @@ static int __ext4_get_inode_loc_noinmem(

    int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc)
    {
    - ext4_fsblk_t err_blk;
    + ext4_fsblk_t err_blk = 0;
    int ret;

    /* We have all inode data except xattrs in memory here. */

    \
     
     \ /
      Last update: 2022-01-25 04:40    [W:3.836 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site