lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 1030/1039] bonding: Fix extraction of ports from the packet headers
    Date
    From: Moshe Tal <moshet@nvidia.com>

    commit 429e3d123d9a50cc9882402e40e0ac912d88cfcf upstream.

    Wrong hash sends single stream to multiple output interfaces.

    The offset calculation was relative to skb->head, fix it to be relative
    to skb->data.

    Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with
    xdp_buff")
    Reviewed-by: Jussi Maki <joamaki@gmail.com>
    Reviewed-by: Saeed Mahameed <saeedm@nvidia.com>
    Reviewed-by: Gal Pressman <gal@nvidia.com>
    Signed-off-by: Moshe Tal <moshet@nvidia.com>
    Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/bonding/bond_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -3872,8 +3872,8 @@ u32 bond_xmit_hash(struct bonding *bond,
    skb->l4_hash)
    return skb->hash;

    - return __bond_xmit_hash(bond, skb, skb->head, skb->protocol,
    - skb->mac_header, skb->network_header,
    + return __bond_xmit_hash(bond, skb, skb->data, skb->protocol,
    + skb_mac_offset(skb), skb_network_offset(skb),
    skb_headlen(skb));
    }


    \
     
     \ /
      Last update: 2022-01-25 04:09    [W:4.299 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site