lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 518/563] clk: si5341: Fix clock HW provider cleanup
    Date
    From: Robert Hancock <robert.hancock@calian.com>

    commit 49a8f2bc8d88702783c7e163ec84374e9a022f71 upstream.

    The call to of_clk_add_hw_provider was not undone on remove or on probe
    failure, which could cause an oops on a subsequent attempt to retrieve
    clocks for the removed device. Switch to the devm version of the
    function to avoid this issue.

    Fixes: 3044a860fd09 ("clk: Add Si5341/Si5340 driver")
    Signed-off-by: Robert Hancock <robert.hancock@calian.com>
    Link: https://lore.kernel.org/r/20220112203816.1784610-1-robert.hancock@calian.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/clk/clk-si5341.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/clk/clk-si5341.c
    +++ b/drivers/clk/clk-si5341.c
    @@ -1576,7 +1576,7 @@ static int si5341_probe(struct i2c_clien
    clk_prepare(data->clk[i].hw.clk);
    }

    - err = of_clk_add_hw_provider(client->dev.of_node, of_clk_si5341_get,
    + err = devm_of_clk_add_hw_provider(&client->dev, of_clk_si5341_get,
    data);
    if (err) {
    dev_err(&client->dev, "unable to add clk provider\n");

    \
     
     \ /
      Last update: 2022-01-25 04:09    [W:4.060 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site