lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 592/846] ACPICA: Fix wrong interpretation of PCC address
    Date
    From: Sudeep Holla <sudeep.holla@arm.com>

    [ Upstream commit 9a3b8655db1ada31c82189ae13f40eb25da48c35 ]

    ACPICA commit 41be6afacfdaec2dba3a5ed368736babc2a7aa5c

    With the PCC Opregion in the firmware and we are hitting below kernel crash:

    -->8
    Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
    Workqueue: pm pm_runtime_work
    pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
    pc : __memcpy+0x54/0x260
    lr : acpi_ex_write_data_to_field+0xb8/0x194
    Call trace:
    __memcpy+0x54/0x260
    acpi_ex_store_object_to_node+0xa4/0x1d4
    acpi_ex_store+0x44/0x164
    acpi_ex_opcode_1A_1T_1R+0x25c/0x508
    acpi_ds_exec_end_op+0x1b4/0x44c
    acpi_ps_parse_loop+0x3a8/0x614
    acpi_ps_parse_aml+0x90/0x2f4
    acpi_ps_execute_method+0x11c/0x19c
    acpi_ns_evaluate+0x1ec/0x2b0
    acpi_evaluate_object+0x170/0x2b0
    acpi_device_set_power+0x118/0x310
    acpi_dev_suspend+0xd4/0x180
    acpi_subsys_runtime_suspend+0x28/0x38
    __rpm_callback+0x74/0x328
    rpm_suspend+0x2d8/0x624
    pm_runtime_work+0xa4/0xb8
    process_one_work+0x194/0x25c
    worker_thread+0x260/0x49c
    kthread+0x14c/0x30c
    ret_from_fork+0x10/0x20
    Code: f9000006 f81f80a7 d65f03c0 361000c2 (b9400026)
    ---[ end trace 24d8a032fa77b68a ]---

    The reason for the crash is that the PCC channel index passed via region.address
    in acpi_ex_store_object_to_node is interpreted as the channel subtype
    incorrectly.

    Assuming the PCC op_region support is not used by any other type, let us
    remove the subtype check as the AML has no access to the subtype information.
    Once we remove it, the kernel crash disappears and correctly complains about
    missing PCC Opregion handler.

    ACPI Error: No handler for Region [PFRM] ((____ptrval____)) [PCC] (20210730/evregion-130)
    ACPI Error: Region PCC (ID=10) has no handler (20210730/exfldio-261)
    ACPI Error: Aborting method \_SB.ETH0._PS3 due to previous error (AE_NOT_EXIST) (20210730/psparse-531)

    Link: https://github.com/acpica/acpica/commit/41be6afa
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Bob Moore <robert.moore@intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/acpica/exfield.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c
    index 06f3c9df1e22d..8618500f23b39 100644
    --- a/drivers/acpi/acpica/exfield.c
    +++ b/drivers/acpi/acpica/exfield.c
    @@ -330,12 +330,7 @@ acpi_ex_write_data_to_field(union acpi_operand_object *source_desc,
    obj_desc->field.base_byte_offset,
    source_desc->buffer.pointer, data_length);

    - if ((obj_desc->field.region_obj->region.address ==
    - PCC_MASTER_SUBSPACE
    - && MASTER_SUBSPACE_COMMAND(obj_desc->field.
    - base_byte_offset))
    - || GENERIC_SUBSPACE_COMMAND(obj_desc->field.
    - base_byte_offset)) {
    + if (MASTER_SUBSPACE_COMMAND(obj_desc->field.base_byte_offset)) {

    /* Perform the write */

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:4.030 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site