lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 365/846] net: openvswitch: Fix matching zone id for invalid conns arriving from tc
    Date
    From: Paul Blakey <paulb@nvidia.com>

    [ Upstream commit 635d448a1cce4b4ebee52b351052c70434fa90ea ]

    Zone id is not restored if we passed ct and ct rejected the connection,
    as there is no ct info on the skb.

    Save the zone from tc skb cb to tc skb extension and pass it on to
    ovs, use that info to restore the zone id for invalid connections.

    Fixes: d29334c15d33 ("net/sched: act_api: fix miss set post_ct for ovs after do conntrack in act_ct")
    Signed-off-by: Paul Blakey <paulb@nvidia.com>
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/skbuff.h | 1 +
    net/openvswitch/flow.c | 8 +++++++-
    net/sched/cls_api.c | 1 +
    3 files changed, 9 insertions(+), 1 deletion(-)

    diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
    index 4f31ca71a82a7..f92839b726dc2 100644
    --- a/include/linux/skbuff.h
    +++ b/include/linux/skbuff.h
    @@ -286,6 +286,7 @@ struct nf_bridge_info {
    struct tc_skb_ext {
    __u32 chain;
    __u16 mru;
    + __u16 zone;
    bool post_ct;
    };
    #endif
    diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
    index 9713035b89e3a..6d262d9aa10ea 100644
    --- a/net/openvswitch/flow.c
    +++ b/net/openvswitch/flow.c
    @@ -34,6 +34,7 @@
    #include <net/mpls.h>
    #include <net/ndisc.h>
    #include <net/nsh.h>
    +#include <net/netfilter/nf_conntrack_zones.h>

    #include "conntrack.h"
    #include "datapath.h"
    @@ -860,6 +861,7 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,
    #endif
    bool post_ct = false;
    int res, err;
    + u16 zone = 0;

    /* Extract metadata from packet. */
    if (tun_info) {
    @@ -898,6 +900,7 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,
    key->recirc_id = tc_ext ? tc_ext->chain : 0;
    OVS_CB(skb)->mru = tc_ext ? tc_ext->mru : 0;
    post_ct = tc_ext ? tc_ext->post_ct : false;
    + zone = post_ct ? tc_ext->zone : 0;
    } else {
    key->recirc_id = 0;
    }
    @@ -906,8 +909,11 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,
    #endif

    err = key_extract(skb, key);
    - if (!err)
    + if (!err) {
    ovs_ct_fill_key(skb, key, post_ct); /* Must be after key_extract(). */
    + if (post_ct && !skb_get_nfct(skb))
    + key->ct_zone = zone;
    + }
    return err;
    }

    diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
    index ff8a9383bf1c4..35c74bdde848e 100644
    --- a/net/sched/cls_api.c
    +++ b/net/sched/cls_api.c
    @@ -1625,6 +1625,7 @@ int tcf_classify(struct sk_buff *skb,
    ext->chain = last_executed_chain;
    ext->mru = cb->mru;
    ext->post_ct = cb->post_ct;
    + ext->zone = cb->zone;
    }

    return ret;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:2.250 / U:0.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site