lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 495/846] drm/amdgpu/display: set vblank_disable_immediate for DC
    Date
    From: Alex Deucher <alexander.deucher@amd.com>

    [ Upstream commit 92020e81ddbeac351ea4a19bcf01743f32b9c800 ]

    Disable vblanks immediately to save power. I think this was
    missed when we merged DC support.

    Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1781
    Reviewed-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
    2 files changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    index cc2e0c9cfe0a1..4f3c62adccbde 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    @@ -333,7 +333,6 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
    if (!amdgpu_device_has_dc_support(adev)) {
    if (!adev->enable_virtual_display)
    /* Disable vblank IRQs aggressively for power-saving */
    - /* XXX: can this be enabled for DC? */
    adev_to_drm(adev)->vblank_disable_immediate = true;

    r = drm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc);
    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index 2fbaf6f869bfb..16556ae892d4a 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -1279,6 +1279,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
    adev_to_drm(adev)->mode_config.cursor_width = adev->dm.dc->caps.max_cursor_size;
    adev_to_drm(adev)->mode_config.cursor_height = adev->dm.dc->caps.max_cursor_size;

    + /* Disable vblank IRQs aggressively for power-saving */
    + adev_to_drm(adev)->vblank_disable_immediate = true;
    +
    if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
    DRM_ERROR(
    "amdgpu: failed to initialize sw for display support.\n");
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:2.885 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site