lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 468/846] selftests/bpf: Fix bpf_object leak in skb_ctx selftest
    Date
    From: Andrii Nakryiko <andrii@kernel.org>

    [ Upstream commit 8c7a95520184b6677ca6075e12df9c208d57d088 ]

    skb_ctx selftest didn't close bpf_object implicitly allocated by
    bpf_prog_test_load() helper. Fix the problem by explicitly calling
    bpf_object__close() at the end of the test.

    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Reviewed-by: Hengqi Chen <hengqi.chen@gmail.com>
    Link: https://lore.kernel.org/bpf/20211107165521.9240-10-andrii@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/skb_ctx.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/testing/selftests/bpf/prog_tests/skb_ctx.c b/tools/testing/selftests/bpf/prog_tests/skb_ctx.c
    index fafeddaad6a99..23915be6172d6 100644
    --- a/tools/testing/selftests/bpf/prog_tests/skb_ctx.c
    +++ b/tools/testing/selftests/bpf/prog_tests/skb_ctx.c
    @@ -105,4 +105,6 @@ void test_skb_ctx(void)
    "ctx_out_mark",
    "skb->mark == %u, expected %d\n",
    skb.mark, 10);
    +
    + bpf_object__close(obj);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:2.106 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site