[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 5.16 0929/1039] powerpc/cell: Fix clang -Wimplicit-fallthrough warning
    From: Anders Roxell <>

    commit e89257e28e844f5d1d39081bb901d9f1183a7705 upstream.

    Clang warns:

    arch/powerpc/platforms/cell/pervasive.c:81:2: error: unannotated fall-through between switch labels
    case SRR1_WAKEEE:
    arch/powerpc/platforms/cell/pervasive.c:81:2: note: insert 'break;' to avoid fall-through
    case SRR1_WAKEEE:
    1 error generated.

    Clang is more pedantic than GCC, which does not warn when failing
    through to a case that is just break or return. Clang's version is more
    in line with the kernel's own stance in deprecated.rst. Add athe missing
    break to silence the warning.

    Fixes: 6e83985b0f6e ("powerpc/cbe: Do not process external or decremeter interrupts from sreset")
    Reported-by: Naresh Kamboju <>
    Signed-off-by: Anders Roxell <>
    Reviewed-by: Nathan Chancellor <>
    Reviewed-by: Arnd Bergmann <>
    Signed-off-by: Michael Ellerman <>
    Signed-off-by: Greg Kroah-Hartman <>
    arch/powerpc/platforms/cell/pervasive.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/powerpc/platforms/cell/pervasive.c
    +++ b/arch/powerpc/platforms/cell/pervasive.c
    @@ -78,6 +78,7 @@ static int cbe_system_reset_exception(st
    switch (regs->msr & SRR1_WAKEMASK) {
    case SRR1_WAKEDEC:
    + break;
    case SRR1_WAKEEE:
    * Handle these when interrupts get re-enabled and we take

     \ /
      Last update: 2022-01-25 00:11    [W:2.367 / U:1.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site