lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0996/1039] dmaengine: at_xdmac: Print debug message after realeasing the lock
    Date
    From: Tudor Ambarus <tudor.ambarus@microchip.com>

    commit 5edc24ac876a928f36f407a0fcdb33b94a3a210f upstream.

    It is desirable to do the prints without the lock held if possible, so
    move the print after the lock is released.

    Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
    Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    Link: https://lore.kernel.org/r/20211215110115.191749-4-tudor.ambarus@microchip.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/at_xdmac.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/dma/at_xdmac.c
    +++ b/drivers/dma/at_xdmac.c
    @@ -473,10 +473,12 @@ static dma_cookie_t at_xdmac_tx_submit(s
    spin_lock_irqsave(&atchan->lock, irqflags);
    cookie = dma_cookie_assign(tx);

    - dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",
    - __func__, atchan, desc);
    list_add_tail(&desc->xfer_node, &atchan->xfers_list);
    spin_unlock_irqrestore(&atchan->lock, irqflags);
    +
    + dev_vdbg(chan2dev(tx->chan), "%s: atchan 0x%p, add desc 0x%p to xfers_list\n",
    + __func__, atchan, desc);
    +
    return cookie;
    }


    \
     
     \ /
      Last update: 2022-01-24 23:54    [W:2.656 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site