lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0664/1039] crypto: hisilicon/hpre - fix memory leak in hpre_curve25519_src_init()
    Date
    From: Weili Qian <qianweili@huawei.com>

    [ Upstream commit 51fa916b81e5f406a74f14a31a3a228c3cc060ad ]

    hpre_curve25519_src_init() allocates memory for 'ptr' before calling
    memcmp(). If memcmp() returns 0, the function will return '-EINVAL'
    without freeing memory.

    Signed-off-by: Weili Qian <qianweili@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
    index a032c192ef1d6..7ba7641723a0b 100644
    --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
    +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
    @@ -1865,7 +1865,7 @@ static int hpre_curve25519_src_init(struct hpre_asym_request *hpre_req,
    */
    if (memcmp(ptr, p, ctx->key_sz) == 0) {
    dev_err(dev, "gx is p!\n");
    - return -EINVAL;
    + goto err;
    } else if (memcmp(ptr, p, ctx->key_sz) > 0) {
    hpre_curve25519_src_modulo_p(ptr);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:40    [W:3.721 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site