lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0653/1039] media: rockchip: rkisp1: use device name for debugfs subdir name
    Date
    From: Mikhail Rudenko <mike.rudenko@gmail.com>

    [ Upstream commit c2611e479f5d9b05108270e1ab423955486b4457 ]

    While testing Rockchip RK3399 with both ISPs enabled, a dmesg error
    was observed:
    ```
    [ 15.559141] debugfs: Directory 'rkisp1' with parent '/' already present!
    ```

    Fix it by using the device name for the debugfs subdirectory name
    instead of the driver name, thus preventing name collision.

    Link: https://lore.kernel.org/linux-media/20211010175457.438627-1-mike.rudenko@gmail.com
    Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
    Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
    index 50b166c49a03a..3f5cfa7eb9372 100644
    --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
    +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
    @@ -462,7 +462,7 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
    {
    struct rkisp1_debug *debug = &rkisp1->debug;

    - debug->debugfs_dir = debugfs_create_dir(RKISP1_DRIVER_NAME, NULL);
    + debug->debugfs_dir = debugfs_create_dir(dev_name(rkisp1->dev), NULL);
    debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir,
    &debug->data_loss);
    debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir,
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:40    [W:2.634 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site