lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 816/846] dmaengine: at_xdmac: Start transfer for cyclic channels in issue_pending
    Date
    From: Tudor Ambarus <tudor.ambarus@microchip.com>

    commit e6af9b05bec63cd4d1de2a33968cd0be2a91282a upstream.

    Cyclic channels must too call issue_pending in order to start a transfer.
    Start the transfer in issue_pending regardless of the type of channel.
    This wrongly worked before, because in the past the transfer was started
    at tx_submit level when only a desc in the transfer list.

    Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
    Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
    Link: https://lore.kernel.org/r/20211215110115.191749-3-tudor.ambarus@microchip.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/at_xdmac.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    --- a/drivers/dma/at_xdmac.c
    +++ b/drivers/dma/at_xdmac.c
    @@ -1778,11 +1778,9 @@ static void at_xdmac_issue_pending(struc

    dev_dbg(chan2dev(&atchan->chan), "%s\n", __func__);

    - if (!at_xdmac_chan_is_cyclic(atchan)) {
    - spin_lock_irqsave(&atchan->lock, flags);
    - at_xdmac_advance_work(atchan);
    - spin_unlock_irqrestore(&atchan->lock, flags);
    - }
    + spin_lock_irqsave(&atchan->lock, flags);
    + at_xdmac_advance_work(atchan);
    + spin_unlock_irqrestore(&atchan->lock, flags);

    return;
    }

    \
     
     \ /
      Last update: 2022-01-24 23:11    [W:2.435 / U:2.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site