lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0255/1039] ath11k: Fix QMI file type enum value
    Date
    From: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>

    [ Upstream commit 18ae1ab04525507ae5528245a6df004cacd0d39a ]

    bdf_type for caldata in QMI_WLANFW_BDF_DOWNLOAD_REQ_V01 is wrongly
    sent as 1. But, expected bdf_type value for caldata and EEPROM is 2 and 3
    respectively. It leads to firmware crash. Fix ath11k_qmi_file_type enum
    values.

    Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1
    Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1

    Fixes: 336e7b53c82f ("ath11k: clean up BDF download functions")
    Signed-off-by: Seevalamuthu Mariappan <quic_seevalam@quicinc.com>
    Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
    Link: https://lore.kernel.org/r/1638182754-18408-1-git-send-email-quic_seevalam@quicinc.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath11k/qmi.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath11k/qmi.h b/drivers/net/wireless/ath/ath11k/qmi.h
    index 3bb0f9ef79968..d9e95b7007653 100644
    --- a/drivers/net/wireless/ath/ath11k/qmi.h
    +++ b/drivers/net/wireless/ath/ath11k/qmi.h
    @@ -41,7 +41,7 @@ struct ath11k_base;

    enum ath11k_qmi_file_type {
    ATH11K_QMI_FILE_TYPE_BDF_GOLDEN,
    - ATH11K_QMI_FILE_TYPE_CALDATA,
    + ATH11K_QMI_FILE_TYPE_CALDATA = 2,
    ATH11K_QMI_FILE_TYPE_EEPROM,
    ATH11K_QMI_MAX_FILE_TYPE,
    };
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:2.199 / U:2.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site