lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 370/563] cpufreq: Fix initialization of min and max frequency QoS requests
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    [ Upstream commit 521223d8b3ec078f670c7c35a1a04b1b2af07966 ]

    The min and max frequency QoS requests in the cpufreq core are
    initialized to whatever the current min and max frequency values are
    at the init time, but if any of these values change later (for
    example, cpuinfo.max_freq is updated by the driver), these initial
    request values will be limiting the CPU frequency unnecessarily
    unless they are changed by user space via sysfs.

    To address this, initialize min_freq_req and max_freq_req to
    FREQ_QOS_MIN_DEFAULT_VALUE and FREQ_QOS_MAX_DEFAULT_VALUE,
    respectively, so they don't really limit anything until user
    space updates them.

    Reported-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Tested-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cpufreq/cpufreq.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    index 8e159fb6af9cd..30dafe8fc5054 100644
    --- a/drivers/cpufreq/cpufreq.c
    +++ b/drivers/cpufreq/cpufreq.c
    @@ -1400,7 +1400,7 @@ static int cpufreq_online(unsigned int cpu)

    ret = freq_qos_add_request(&policy->constraints,
    policy->min_freq_req, FREQ_QOS_MIN,
    - policy->min);
    + FREQ_QOS_MIN_DEFAULT_VALUE);
    if (ret < 0) {
    /*
    * So we don't call freq_qos_remove_request() for an
    @@ -1420,7 +1420,7 @@ static int cpufreq_online(unsigned int cpu)

    ret = freq_qos_add_request(&policy->constraints,
    policy->max_freq_req, FREQ_QOS_MAX,
    - policy->max);
    + FREQ_QOS_MAX_DEFAULT_VALUE);
    if (ret < 0) {
    policy->max_freq_req = NULL;
    goto out_destroy_policy;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:3.247 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site