lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0390/1039] usb: dwc2: do not gate off the hardware if it does not support clock gating
    Date
    From: Dinh Nguyen <dinguyen@kernel.org>

    [ Upstream commit 34146c68083f1aef6709196b3dc888c1ceffd357 ]

    We should not be clearing the HCD_FLAG_HW_ACCESSIBLE bit if the hardware
    does not support clock gating.

    Fixes: 50fb0c128b6e ("usb: dwc2: Add clock gating entering flow by system suspend")
    Acked-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
    Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
    Link: https://lore.kernel.org/r/20220104135922.734776-1-dinguyen@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc2/hcd.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
    index 13c779a28e94f..f63a27d11fac8 100644
    --- a/drivers/usb/dwc2/hcd.c
    +++ b/drivers/usb/dwc2/hcd.c
    @@ -4399,11 +4399,12 @@ static int _dwc2_hcd_suspend(struct usb_hcd *hcd)
    * If not hibernation nor partial power down are supported,
    * clock gating is used to save power.
    */
    - if (!hsotg->params.no_clock_gating)
    + if (!hsotg->params.no_clock_gating) {
    dwc2_host_enter_clock_gating(hsotg);

    - /* After entering suspend, hardware is not accessible */
    - clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
    + /* After entering suspend, hardware is not accessible */
    + clear_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
    + }
    break;
    default:
    goto skip_power_saving;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:4.029 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site