lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0120/1039] media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 85db29d22cc521d9d06de2f5c7832981a55df157 ]

    Return -ENODEV if acpi_get_physical_device_location() fails. Don't
    return success.

    Fixes: 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Daniel Scally <djrscally@gmail.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c
    index 67c467d3c81f9..0b586b4e537ef 100644
    --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c
    +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c
    @@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
    goto err_put_adev;

    status = acpi_get_physical_device_location(adev->handle, &sensor->pld);
    - if (ACPI_FAILURE(status))
    + if (ACPI_FAILURE(status)) {
    + ret = -ENODEV;
    goto err_put_adev;
    + }

    if (sensor->ssdb.lanes > CIO2_MAX_LANES) {
    dev_err(&adev->dev,
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:3.168 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site