lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0008/1039] ALSA: core: Fix SSID quirk lookup for subvendor=0
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 5576c4f24c56722a2d9fb9c447d896e5b312078b upstream.

    Some weird devices set the codec SSID vendor ID 0, and
    snd_pci_quirk_lookup_id() loop aborts at the point although it should
    still try matching with the SSID device ID. This resulted in a
    missing quirk for some old Macs.

    Fix the loop termination condition to check both subvendor and
    subdevice.

    Fixes: 73355ddd8775 ("ALSA: hda: Code refactoring snd_hda_pick_fixup()")
    Cc: <stable@vger.kernel.org>
    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215495
    Link: https://lore.kernel.org/r/20220116082838.19382-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/core/misc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/misc.c
    +++ b/sound/core/misc.c
    @@ -112,7 +112,7 @@ snd_pci_quirk_lookup_id(u16 vendor, u16
    {
    const struct snd_pci_quirk *q;

    - for (q = list; q->subvendor; q++) {
    + for (q = list; q->subvendor || q->subdevice; q++) {
    if (q->subvendor != vendor)
    continue;
    if (!q->subdevice ||

    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:2.931 / U:1.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site