lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0517/1039] powerpc/xive: Add missing null check after calling kmalloc
    Date
    From: Ammar Faizi <ammarfaizi2@gmail.com>

    [ Upstream commit 18dbfcdedc802f9500b2c29794f22a31d27639c0 ]

    Commit 930914b7d528fc ("powerpc/xive: Add a debugfs file to dump
    internal XIVE state") forgot to add a null check.

    Add it.

    Fixes: 930914b7d528fc6b0249bffc00564100bcf6ef75 ("powerpc/xive: Add a debugfs file to dump internal XIVE state")
    Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
    Reviewed-by: Cédric Le Goater <clg@kaod.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20211226135314.251221-1-ammar.faizi@intel.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/xive/spapr.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c
    index f143b6f111ac0..1179632560b8d 100644
    --- a/arch/powerpc/sysdev/xive/spapr.c
    +++ b/arch/powerpc/sysdev/xive/spapr.c
    @@ -653,6 +653,9 @@ static int xive_spapr_debug_show(struct seq_file *m, void *private)
    struct xive_irq_bitmap *xibm;
    char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);

    + if (!buf)
    + return -ENOMEM;
    +
    list_for_each_entry(xibm, &xive_irq_bitmaps, list) {
    memset(buf, 0, PAGE_SIZE);
    bitmap_print_to_pagebuf(true, buf, xibm->bitmap, xibm->count);
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:2.804 / U:0.980 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site