lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0123/1039] media: atomisp: fix inverted logic in buffers_needed()
    Date
    From: Tsuchiya Yuto <kitakar@gmail.com>

    [ Upstream commit e1921cd14640f0f4d1fad5eb8e448c58a536415d ]

    When config.mode is IA_CSS_INPUT_MODE_BUFFERED_SENSOR, it rather needs
    buffers. Fix it by inverting the return value.

    Fixes: 3c0538fbad9f ("media: atomisp: get rid of most checks for ISP2401 version")
    Signed-off-by: Tsuchiya Yuto <kitakar@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/atomisp/pci/sh_css_mipi.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    index 75489f7d75eec..483d40a467c74 100644
    --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
    @@ -374,17 +374,17 @@ static bool buffers_needed(struct ia_css_pipe *pipe)
    {
    if (!IS_ISP2401) {
    if (pipe->stream->config.mode == IA_CSS_INPUT_MODE_BUFFERED_SENSOR)
    - return false;
    - else
    return true;
    + else
    + return false;
    }

    if (pipe->stream->config.mode == IA_CSS_INPUT_MODE_BUFFERED_SENSOR ||
    pipe->stream->config.mode == IA_CSS_INPUT_MODE_TPG ||
    pipe->stream->config.mode == IA_CSS_INPUT_MODE_PRBS)
    - return false;
    + return true;

    - return true;
    + return false;
    }

    int
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:09    [W:2.627 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site