lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0543/1039] Bluetooth: Fix removing adv when processing cmd complete
    Date
    From: Archie Pusaka <apusaka@chromium.org>

    [ Upstream commit 2128939fe2e771645dd88e1938c27fdf96bd1cd0 ]

    If we remove one instance of adv using Set Extended Adv Enable, there
    is a possibility of issue occurs when processing the Command Complete
    event. Especially, the adv_info might not be found since we already
    remove it in hci_req_clear_adv_instance() -> hci_remove_adv_instance().
    If that's the case, we will mistakenly proceed to remove all adv
    instances instead of just one single instance.

    This patch fixes the issue by checking the content of the HCI command
    instead of checking whether the adv_info is found.

    Signed-off-by: Archie Pusaka <apusaka@chromium.org>
    Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
    Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/bluetooth/hci_event.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
    index 6eba439487749..8882c6dfb48f4 100644
    --- a/net/bluetooth/hci_event.c
    +++ b/net/bluetooth/hci_event.c
    @@ -1326,8 +1326,10 @@ static void hci_cc_le_set_ext_adv_enable(struct hci_dev *hdev,
    &conn->le_conn_timeout,
    conn->conn_timeout);
    } else {
    - if (adv) {
    - adv->enabled = false;
    + if (cp->num_of_sets) {
    + if (adv)
    + adv->enabled = false;
    +
    /* If just one instance was disabled check if there are
    * any other instance enabled before clearing HCI_LE_ADV
    */
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:09    [W:2.617 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site