lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0243/1039] samples: bpf: Fix unknown warning group build warning on Clang
    Date
    From: Alexander Lobakin <alexandr.lobakin@intel.com>

    [ Upstream commit 6f670d06e47c774bc065aaa84a527a4838f34bd8 ]

    Clang doesn't have 'stringop-truncation' group like GCC does, and
    complains about it when building samples which use xdp_sample_user
    infra:

    samples/bpf/xdp_sample_user.h:48:32: warning: unknown warning group '-Wstringop-truncation', ignored [-Wunknown-warning-option]
    #pragma GCC diagnostic ignored "-Wstringop-truncation"
    ^
    [ repeat ]

    Those are harmless, but avoidable when guarding it with ifdef.
    I could guard push/pop as well, but this would require one more
    ifdef cruft around a single line which I don't think is reasonable.

    Fixes: 156f886cf697 ("samples: bpf: Add basic infrastructure for XDP samples")
    Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
    Link: https://lore.kernel.org/bpf/20211203195004.5803-3-alexandr.lobakin@intel.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    samples/bpf/xdp_sample_user.h | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/samples/bpf/xdp_sample_user.h b/samples/bpf/xdp_sample_user.h
    index d97465ff8c62c..5f44b877ecf5f 100644
    --- a/samples/bpf/xdp_sample_user.h
    +++ b/samples/bpf/xdp_sample_user.h
    @@ -45,7 +45,9 @@ const char *get_driver_name(int ifindex);
    int get_mac_addr(int ifindex, void *mac_addr);

    #pragma GCC diagnostic push
    +#ifndef __clang__
    #pragma GCC diagnostic ignored "-Wstringop-truncation"
    +#endif
    __attribute__((unused))
    static inline char *safe_strncpy(char *dst, const char *src, size_t size)
    {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:09    [W:3.202 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site