lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 489/846] ethernet: renesas: Use div64_ul instead of do_div
    Date
    From: Yang Li <yang.lee@linux.alibaba.com>

    [ Upstream commit d9f31aeaa1e5aefa68130878af3c3513d41c1e2d ]

    do_div() does a 64-by-32 division. Here the divisor is an
    unsigned long which on some platforms is 64 bit wide. So use
    div64_ul instead of do_div to avoid a possible truncation.

    Eliminate the following coccicheck warning:
    ./drivers/net/ethernet/renesas/ravb_main.c:2492:1-7: WARNING:
    do_div() does a 64-by-32 division, please consider using div64_ul
    instead.

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
    Link: https://lore.kernel.org/r/1637228883-100100-1-git-send-email-yang.lee@linux.alibaba.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/renesas/ravb_main.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
    index 0f85f2d97b18d..4e08b7219403c 100644
    --- a/drivers/net/ethernet/renesas/ravb_main.c
    +++ b/drivers/net/ethernet/renesas/ravb_main.c
    @@ -30,8 +30,7 @@
    #include <linux/spinlock.h>
    #include <linux/sys_soc.h>
    #include <linux/reset.h>
    -
    -#include <asm/div64.h>
    +#include <linux/math64.h>

    #include "ravb.h"

    @@ -2061,8 +2060,7 @@ static int ravb_set_gti(struct net_device *ndev)
    if (!rate)
    return -EINVAL;

    - inc = 1000000000ULL << 20;
    - do_div(inc, rate);
    + inc = div64_ul(1000000000ULL << 20, rate);

    if (inc < GTI_TIV_MIN || inc > GTI_TIV_MAX) {
    dev_err(dev, "gti.tiv increment 0x%llx is outside the range 0x%x - 0x%x\n",
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 22:41    [W:4.114 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site