lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 284/563] ASoC: samsung: idma: Check of ioremap return value
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 3ecb46755eb85456b459a1a9f952c52986bce8ec ]

    Because of the potential failure of the ioremap(), the buf->area could
    be NULL.
    Therefore, we need to check it and return -ENOMEM in order to transfer
    the error.

    Fixes: f09aecd50f39 ("ASoC: SAMSUNG: Add I2S0 internal dma driver")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Link: https://lore.kernel.org/r/20211228034026.1659385-1-jiasheng@iscas.ac.cn
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/samsung/idma.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/samsung/idma.c b/sound/soc/samsung/idma.c
    index 66bcc2f97544b..c3f1b054e2389 100644
    --- a/sound/soc/samsung/idma.c
    +++ b/sound/soc/samsung/idma.c
    @@ -360,6 +360,8 @@ static int preallocate_idma_buffer(struct snd_pcm *pcm, int stream)
    buf->addr = idma.lp_tx_addr;
    buf->bytes = idma_hardware.buffer_bytes_max;
    buf->area = (unsigned char * __force)ioremap(buf->addr, buf->bytes);
    + if (!buf->area)
    + return -ENOMEM;

    return 0;
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 22:41    [W:2.642 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site