lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 394/563] btrfs: remove BUG_ON(!eie) in find_parent_nodes
    Date
    From: Josef Bacik <josef@toxicpanda.com>

    [ Upstream commit 9f05c09d6baef789726346397438cca4ec43c3ee ]

    If we're looking for leafs that point to a data extent we want to record
    the extent items that point at our bytenr. At this point we have the
    reference and we know for a fact that this leaf should have a reference
    to our bytenr. However if there's some sort of corruption we may not
    find any references to our leaf, and thus could end up with eie == NULL.
    Replace this BUG_ON() with an ASSERT() and then return -EUCLEAN for the
    mortals.

    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/backref.c | 14 +++++++++++---
    1 file changed, 11 insertions(+), 3 deletions(-)

    diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
    index 8b471579e26e1..baff31a147e7d 100644
    --- a/fs/btrfs/backref.c
    +++ b/fs/btrfs/backref.c
    @@ -1366,10 +1366,18 @@ again:
    goto out;
    if (!ret && extent_item_pos) {
    /*
    - * we've recorded that parent, so we must extend
    - * its inode list here
    + * We've recorded that parent, so we must extend
    + * its inode list here.
    + *
    + * However if there was corruption we may not
    + * have found an eie, return an error in this
    + * case.
    */
    - BUG_ON(!eie);
    + ASSERT(eie);
    + if (!eie) {
    + ret = -EUCLEAN;
    + goto out;
    + }
    while (eie->next)
    eie = eie->next;
    eie->next = ref->inode_list;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 21:40    [W:2.274 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site