lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 492/563] Documentation: ACPI: Fix data node reference documentation
    Date
    From: Sakari Ailus <sakari.ailus@linux.intel.com>

    commit a11174952205d082f1658fab4314f0caf706e0a8 upstream.

    The data node reference documentation was missing a package that must
    contain the property values, instead property name and multiple values
    being present in a single package. This is not aligned with the _DSD
    spec.

    Fix it by adding the package for the values.

    Also add the missing "reg" properties to two numbered nodes.

    Fixes: b10134a3643d ("ACPI: property: Document hierarchical data extension references")
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    Documentation/firmware-guide/acpi/dsd/data-node-references.rst | 10 ++++++++--
    1 file changed, 8 insertions(+), 2 deletions(-)

    --- a/Documentation/firmware-guide/acpi/dsd/data-node-references.rst
    +++ b/Documentation/firmware-guide/acpi/dsd/data-node-references.rst
    @@ -5,7 +5,7 @@
    Referencing hierarchical data nodes
    ===================================

    -:Copyright: |copy| 2018 Intel Corporation
    +:Copyright: |copy| 2018, 2021 Intel Corporation
    :Author: Sakari Ailus <sakari.ailus@linux.intel.com>

    ACPI in general allows referring to device objects in the tree only.
    @@ -52,12 +52,14 @@ the ANOD object which is also the final
    Name (NOD0, Package() {
    ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    Package () {
    + Package () { "reg", 0 },
    Package () { "random-property", 3 },
    }
    })
    Name (NOD1, Package() {
    ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
    Package () {
    + Package () { "reg", 1 },
    Package () { "anothernode", "ANOD" },
    }
    })
    @@ -74,7 +76,11 @@ the ANOD object which is also the final
    Name (_DSD, Package () {
    ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
    Package () {
    - Package () { "reference", ^DEV0, "node@1", "anothernode" },
    + Package () {
    + "reference", Package () {
    + ^DEV0, "node@1", "anothernode"
    + }
    + },
    }
    })
    }

    \
     
     \ /
      Last update: 2022-01-24 21:40    [W:2.095 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site