lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 411/563] powerpc/cell: add missing of_node_put
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    [ Upstream commit a841fd009e51c8c0a8f07c942e9ab6bb48da8858 ]

    for_each_node_by_name performs an of_node_get on each iteration, so
    a break out of the loop requires an of_node_put.

    A simplified version of the semantic patch that fixes this problem is as
    follows (http://coccinelle.lip6.fr):

    // <smpl>
    @@
    expression e,e1;
    local idexpression n;
    @@

    for_each_node_by_name(n, e1) {
    ... when != of_node_put(n)
    when != e = n
    (
    return n;
    |
    + of_node_put(n);
    ? return ...;
    )
    ...
    }
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1448051604-25256-7-git-send-email-Julia.Lawall@lip6.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/cell/iommu.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
    index 2124831cf57c0..d04079b34d7c2 100644
    --- a/arch/powerpc/platforms/cell/iommu.c
    +++ b/arch/powerpc/platforms/cell/iommu.c
    @@ -976,6 +976,7 @@ static int __init cell_iommu_fixed_mapping_init(void)
    if (hbase < dbase || (hend > (dbase + dsize))) {
    pr_debug("iommu: hash window doesn't fit in"
    "real DMA window\n");
    + of_node_put(np);
    return -1;
    }
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 21:40    [W:2.612 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site