lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 158/320] ARM: shmobile: rcar-gen2: Add missing of_node_put()
    Date
    From: Wan Jiabing <wanjiabing@vivo.com>

    [ Upstream commit 85744f2d938c5f3cfc44cb6533c157469634da93 ]

    Fix following coccicheck warning:
    ./arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c:156:1-33: Function
    for_each_matching_node_and_match should have of_node_put() before break
    and goto.

    Early exits from for_each_matching_node_and_match() should decrement the
    node reference counter.

    Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
    Link: https://lore.kernel.org/r/20211018014503.7598-1-wanjiabing@vivo.com
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
    index ee949255ced3f..09ef73b99dd86 100644
    --- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
    +++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
    @@ -154,8 +154,10 @@ static int __init rcar_gen2_regulator_quirk(void)
    return -ENODEV;

    for_each_matching_node_and_match(np, rcar_gen2_quirk_match, &id) {
    - if (!of_device_is_available(np))
    + if (!of_device_is_available(np)) {
    + of_node_put(np);
    break;
    + }

    ret = of_property_read_u32(np, "reg", &addr);
    if (ret) /* Skip invalid entry and continue */
    @@ -164,6 +166,7 @@ static int __init rcar_gen2_regulator_quirk(void)
    quirk = kzalloc(sizeof(*quirk), GFP_KERNEL);
    if (!quirk) {
    ret = -ENOMEM;
    + of_node_put(np);
    goto err_mem;
    }

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 21:11    [W:2.525 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site