lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 248/320] crypto: caam - replace this_cpu_ptr with raw_cpu_ptr
    Date
    From: Meng Li <Meng.Li@windriver.com>

    commit efd21e10fc3bf4c6da122470a5ae89ec4ed8d180 upstream.

    When enable the kernel debug config, there is below calltrace detected:
    BUG: using smp_processor_id() in preemptible [00000000] code: cryptomgr_test/339
    caller is debug_smp_processor_id+0x20/0x30
    CPU: 9 PID: 339 Comm: cryptomgr_test Not tainted 5.10.63-yocto-standard #1
    Hardware name: NXP Layerscape LX2160ARDB (DT)
    Call trace:
    dump_backtrace+0x0/0x1a0
    show_stack+0x24/0x30
    dump_stack+0xf0/0x13c
    check_preemption_disabled+0x100/0x110
    debug_smp_processor_id+0x20/0x30
    dpaa2_caam_enqueue+0x10c/0x25c
    ......
    cryptomgr_test+0x38/0x60
    kthread+0x158/0x164
    ret_from_fork+0x10/0x38
    According to the comment in commit ac5d15b4519f("crypto: caam/qi2
    - use affine DPIOs "), because preemption is no longer disabled
    while trying to enqueue an FQID, it might be possible to run the
    enqueue on a different CPU(due to migration, when in process context),
    however this wouldn't be a functionality issue. But there will be
    above calltrace when enable kernel debug config. So, replace this_cpu_ptr
    with raw_cpu_ptr to avoid above call trace.

    Fixes: ac5d15b4519f ("crypto: caam/qi2 - use affine DPIOs")
    Cc: stable@vger.kernel.org
    Signed-off-by: Meng Li <Meng.Li@windriver.com>
    Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/caam/caamalg_qi2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/crypto/caam/caamalg_qi2.c
    +++ b/drivers/crypto/caam/caamalg_qi2.c
    @@ -5421,7 +5421,7 @@ int dpaa2_caam_enqueue(struct device *de
    dpaa2_fd_set_len(&fd, dpaa2_fl_get_len(&req->fd_flt[1]));
    dpaa2_fd_set_flc(&fd, req->flc_dma);

    - ppriv = this_cpu_ptr(priv->ppriv);
    + ppriv = raw_cpu_ptr(priv->ppriv);
    for (i = 0; i < (priv->dpseci_attr.num_tx_queues << 1); i++) {
    err = dpaa2_io_service_enqueue_fq(ppriv->dpio, ppriv->req_fqid,
    &fd);

    \
     
     \ /
      Last update: 2022-01-24 21:11    [W:24.001 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site