lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 313/320] net: ethernet: mtk_eth_soc: fix error checking in mtk_mac_config()
    Date
    From: Tom Rix <trix@redhat.com>

    commit 214b3369ab9b0a6f28d6c970220c209417edbc65 upstream.

    Clang static analysis reports this problem
    mtk_eth_soc.c:394:7: warning: Branch condition evaluates
    to a garbage value
    if (err)
    ^~~

    err is not initialized and only conditionally set.
    So intitialize err.

    Fixes: 7e538372694b ("net: ethernet: mediatek: Re-add support SGMII")
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
    +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
    @@ -215,7 +215,7 @@ static void mtk_mac_config(struct phylin
    phylink_config);
    struct mtk_eth *eth = mac->hw;
    u32 mcr_cur, mcr_new, sid, i;
    - int val, ge_mode, err;
    + int val, ge_mode, err = 0;

    /* MT76x8 has no hardware settings between for the MAC */
    if (!MTK_HAS_CAPS(eth->soc->caps, MTK_SOC_MT7628) &&

    \
     
     \ /
      Last update: 2022-01-24 21:09    [W:2.091 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site