lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 045/563] drm/panel: kingdisplay-kd097d04: Delete panel on attach() failure
    Date
    From: Brian Norris <briannorris@chromium.org>

    [ Upstream commit 5f31dbeae8a88f31c3eb4eb526ab4807c40da241 ]

    If we fail to attach (e.g., because 1 of 2 dual-DSI controllers aren't
    ready), we leave a dangling drm_panel reference to freed memory. Clean
    that up on failure.

    Fixes: 2a994cbed6b2 ("drm/panel: Add Kingdisplay KD097D04 panel driver")
    Signed-off-by: Brian Norris <briannorris@chromium.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210923173336.1.Icb4d9dbc1817f4e826361a4f1cea7461541668f0@changeid
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
    index 86e4213e8bb13..daccb1fd5fdad 100644
    --- a/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
    +++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd097d04.c
    @@ -406,7 +406,13 @@ static int kingdisplay_panel_probe(struct mipi_dsi_device *dsi)
    if (err < 0)
    return err;

    - return mipi_dsi_attach(dsi);
    + err = mipi_dsi_attach(dsi);
    + if (err < 0) {
    + kingdisplay_panel_del(kingdisplay);
    + return err;
    + }
    +
    + return 0;
    }

    static int kingdisplay_panel_remove(struct mipi_dsi_device *dsi)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 20:55    [W:4.120 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site