lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 004/563] HID: wacom: Ignore the confidence flag when a touch is removed
    Date
    From: Jason Gerecke <killertofu@gmail.com>

    commit df03e9bd6d4806619b4cdc91a3d7695818a8e2b7 upstream.

    AES hardware may internally re-classify a contact that it thought was
    intentional as a palm. Intentional contacts are reported as "down" with
    the confidence bit set. When this re-classification occurs, however, the
    state transitions to "up" with the confidence bit cleared. This kind of
    transition appears to be legal according to Microsoft docs, but we do
    not handle it correctly. Because the confidence bit is clear, we don't
    call `wacom_wac_finger_slot` and update userspace. This causes hung
    touches that confuse userspace and interfere with pen arbitration.

    This commit adds a special case to ignore the confidence flag if a contact
    is reported as removed. This ensures we do not leave a hung touch if one
    of these re-classification events occured. Ideally we'd have some way to
    also let userspace know that the touch has been re-classified as a palm
    and needs to be canceled, but that's not possible right now :)

    Link: https://github.com/linuxwacom/input-wacom/issues/288
    Fixes: 7fb0413baa7f (HID: wacom: Use "Confidence" flag to prevent reporting invalid contacts)
    CC: stable@vger.kernel.org
    Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
    Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/hid/wacom_wac.c | 29 ++++++++++++++++++++++++++---
    1 file changed, 26 insertions(+), 3 deletions(-)

    --- a/drivers/hid/wacom_wac.c
    +++ b/drivers/hid/wacom_wac.c
    @@ -2566,6 +2566,24 @@ static void wacom_wac_finger_slot(struct
    }
    }

    +static bool wacom_wac_slot_is_active(struct input_dev *dev, int key)
    +{
    + struct input_mt *mt = dev->mt;
    + struct input_mt_slot *s;
    +
    + if (!mt)
    + return false;
    +
    + for (s = mt->slots; s != mt->slots + mt->num_slots; s++) {
    + if (s->key == key &&
    + input_mt_get_value(s, ABS_MT_TRACKING_ID) >= 0) {
    + return true;
    + }
    + }
    +
    + return false;
    +}
    +
    static void wacom_wac_finger_event(struct hid_device *hdev,
    struct hid_field *field, struct hid_usage *usage, __s32 value)
    {
    @@ -2613,9 +2631,14 @@ static void wacom_wac_finger_event(struc
    }

    if (usage->usage_index + 1 == field->report_count) {
    - if (equivalent_usage == wacom_wac->hid_data.last_slot_field &&
    - wacom_wac->hid_data.confidence)
    - wacom_wac_finger_slot(wacom_wac, wacom_wac->touch_input);
    + if (equivalent_usage == wacom_wac->hid_data.last_slot_field) {
    + bool touch_removed = wacom_wac_slot_is_active(wacom_wac->touch_input,
    + wacom_wac->hid_data.id) && !wacom_wac->hid_data.tipswitch;
    +
    + if (wacom_wac->hid_data.confidence || touch_removed) {
    + wacom_wac_finger_slot(wacom_wac, wacom_wac->touch_input);
    + }
    + }
    }
    }


    \
     
     \ /
      Last update: 2022-01-24 20:54    [W:4.090 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site