Messages in this thread |  | | Date | Tue, 11 Jan 2022 16:03:51 +0100 | Subject | Re: [PATCH 1/4] dt-bindings: leds: maxim,max77693: convert to dtschema | From | Krzysztof Kozlowski <> |
| |
On 04/01/2022 16:09, Rob Herring wrote: > On Thu, Dec 30, 2021 at 11:53:37AM +0100, Krzysztof Kozlowski wrote: >> On 29/12/2021 18:34, Rob Herring wrote: >>> On Tue, 28 Dec 2021 17:39:27 +0100, Krzysztof Kozlowski wrote: >>>> Convert the LEDs bindings of Maxim MAX77693 MUIC to DT schema format. >>>> The existing bindings were defined in ../bindings/mfd/max77693.txt. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >>>> --- >>>> .../bindings/leds/maxim,max77693.yaml | 105 ++++++++++++++++++ >>>> 1 file changed, 105 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/leds/maxim,max77693.yaml >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/common.example.dt.yaml: led-controller@0: 'reg' does not match any of the regexes: '^([a-z]+-)?led[01]?$', 'pinctrl-[0-9]+' >>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/maxim,max77693.yaml >>> >>> doc reference errors (make refcheckdocs): >>> Documentation/devicetree/bindings/leds/maxim,max77693.yaml: Documentation/devicetree/bindings/mfd/maxim,max77693.yaml >>> >>> See https://patchwork.ozlabs.org/patch/1573762 >>> >>> This check can fail if there are any dependencies. The base for a patch >>> series is generally the most recent rc1. >>> >> >> I updated my yamllint and dtschema, run with DT_CHECKER_FLAGS=-m but >> still cannot reproduce it. Probably because I based on linux-next, so >> maybe this was a fixed issue in leds/common.yaml. > > Are you setting DT_SCHEMA_FILES, because the error is in > common.yaml but caused by this schema. > > Clearly, 'reg' is not defined here. And there is no change to > common.yaml in next. >
Indeed, I'll fix this up.
Best regards, Krzysztof
|  |