lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 4/4] gpio: dwapb: Get rid of legacy platform data
On Mon, Aug 2, 2021 at 5:23 PM Serge Semin <fancer.lancer@gmail.com> wrote:
> On Mon, Jul 26, 2021 at 03:54:36PM +0300, Andy Shevchenko wrote:
> > Platform data is a legacy interface to supply device properties
> > to the driver. In this case we don't have anymore in-kernel users
> > for it. Just remove it for good.


> > +struct dwapb_port_property {
> > + struct fwnode_handle *fwnode;
> > + unsigned int idx;
> > + unsigned int ngpio;
> > + unsigned int gpio_base;
> > + int irq[DWAPB_MAX_GPIOS];
> > +};
> > +
> > +struct dwapb_platform_data {
> > + struct dwapb_port_property *properties;
> > + unsigned int nports;
> > +};
> > +
> > struct dwapb_gpio;
>
> If you need to resend the series anyway could you please move the
> structures declarations to being below the forward declaration of the
> dwapb_gpio structure? Of course it's not that critical, but for the
> sake of just not to have the later one left somewhere in the middle of
> the unrelated structures and for at least to keep some order in the
> declarations.

Fine with me, I'll modify accordingly in the next version, thanks for
the review!

> Then feel free to add:
> Acked-by: Serge Semin <fancer.lancer@gmail.com>
>
> The whole series has been tested on Baikal-T1 SoC:
> Tested-by: Serge Semin <fancer.lancer@gmail.com>

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-08-02 17:56    [W:0.070 / U:3.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site