lkml.org 
[lkml]   [2021]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] iio: adis: set GPIO reset pin direction
Date


> -----Original Message-----
> From: Antti Keränen <detegr@rbx.email>
> Sent: Thursday, July 8, 2021 11:54 AM
> To: linux-iio@vger.kernel.org
> Cc: Antti Keränen <detegr@rbx.email>; Hannu Hartikainen
> <hannu@hrtk.in>; Lars-Peter Clausen <lars@metafoo.de>; Hennerich,
> Michael <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> open list <linux-kernel@vger.kernel.org>
> Subject: [PATCH v2] iio: adis: set GPIO reset pin direction
>
> Set reset pin direction to output as the reset pin needs to be an active
> low output pin.
>
> Co-developed-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Hannu Hartikainen <hannu@hrtk.in>
> Signed-off-by: Antti Keränen <detegr@rbx.email>
> ---
> Removed unnecessary toggling of the pin as requested by Lars-Peter. I
> missed out on the conversation, but I agree this is better.
>
> drivers/iio/imu/adis.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index 319b64b2fd88..f8b7837d8b8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -415,12 +415,11 @@ int __adis_initial_startup(struct adis *adis)
> int ret;
>
> /* check if the device has rst pin low */
> - gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_ASIS);
> + gpio = devm_gpiod_get_optional(&adis->spi->dev, "reset",
> GPIOD_OUT_HIGH);
> if (IS_ERR(gpio))
> return PTR_ERR(gpio);
>
> if (gpio) {
> - gpiod_set_value_cansleep(gpio, 1);
> msleep(10);
> /* bring device out of reset */
> gpiod_set_value_cansleep(gpio, 0);
> --

Reviewed-by: Nuno Sá <nuno.sa@analog.com>


Thanks!

- Nuno Sá
\
 
 \ /
  Last update: 2021-07-08 12:07    [W:0.138 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site