Messages in this thread |  | | Subject | Re: [PATCH v2 08/10] coresight: trbe: Unify the enabling sequence | From | Anshuman Khandual <> | Date | Fri, 30 Jul 2021 11:10:40 +0530 |
| |
On 7/23/21 6:16 PM, Suzuki K Poulose wrote: > Unify the sequence of enabling the TRBE. We do this from > event_start and also from the TRBE IRQ handler. Lets move > this to a common helper. The only minor functional change > is returning an error when we fail to enable the TRBE. > This should be handled already. > > Cc: Anshuman Khandual <anshuman.khandual@arm.com> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Mike Leach <mike.leach@linaro.org> > Cc: Leo Yan <leo.yan@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > drivers/hwtracing/coresight/coresight-trbe.c | 34 +++++++++++--------- > 1 file changed, 18 insertions(+), 16 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index d50f142e86d1..6d6aad171c72 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -632,6 +632,20 @@ static unsigned long arm_trbe_update_buffer(struct coresight_device *csdev, > return size; > } > > +static int __arm_trbe_enable(struct trbe_buf *buf, > + struct perf_output_handle *handle) > +{ > + buf->trbe_limit = compute_trbe_buffer_limit(handle); > + buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > + if (buf->trbe_limit == buf->trbe_base) { > + trbe_stop_and_truncate_event(handle); > + return -ENOSPC; > + } > + *this_cpu_ptr(buf->cpudata->drvdata->handle) = handle; > + trbe_enable_hw(buf); > + return 0; > +} > + > static int arm_trbe_enable(struct coresight_device *csdev, u32 mode, void *data) > { > struct trbe_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); > @@ -648,14 +662,8 @@ static int arm_trbe_enable(struct coresight_device *csdev, u32 mode, void *data)
There is this (now) redundant assignment which needs to be dropped.
*this_cpu_ptr(buf->cpudata->drvdata->handle) = handle;
> cpudata->buf = buf; > cpudata->mode = mode; > buf->cpudata = cpudata;> - buf->trbe_limit = compute_trbe_buffer_limit(handle); > - buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > - if (buf->trbe_limit == buf->trbe_base) { > - trbe_stop_and_truncate_event(handle); > - return 0; > - } > - trbe_enable_hw(buf); > - return 0; > + > + return __arm_trbe_enable(buf, handle); > } > > static int arm_trbe_disable(struct coresight_device *csdev) > @@ -722,14 +730,8 @@ static void trbe_handle_overflow(struct perf_output_handle *handle) > *this_cpu_ptr(buf->cpudata->drvdata->handle) = NULL; > return; > } > - buf->trbe_limit = compute_trbe_buffer_limit(handle); > - buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); > - if (buf->trbe_limit == buf->trbe_base) { > - trbe_stop_and_truncate_event(handle); > - return; > - } > - *this_cpu_ptr(buf->cpudata->drvdata->handle) = handle; > - trbe_enable_hw(buf); > + > + __arm_trbe_enable(buf, handle); > } > > static bool is_perf_trbe(struct perf_output_handle *handle) > With that, this clean up makes sense.
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
|  |