Messages in this thread |  | | Date | Fri, 30 Jul 2021 18:21:37 -0700 | From | abhinavk@codeauro ... | Subject | Re: [PATCH 0/5] drm/msm/dp: Support multiple DP instances and add sc8180x |
| |
Hi Bjorn
On 2021-07-24 21:24, Bjorn Andersson wrote: > The current implementation supports a single DP instance and the DPU > code will > only match it against INTF_DP instance 0. These patches extends this to > allow > multiple DP instances and support for matching against DP instances > beyond 0. > > This is based on v4 of Dmitry's work on multiple DSI interfaces: > https://lore.kernel.org/linux-arm-msm/20210717124016.316020-1-dmitry.baryshkov@linaro.org/ > > With that in place add SC8180x DP and eDP controllers.
Thanks for posting the changes.
I dont have major concerns on the series as such apart from minor comments which i will post in a day or two but I will check and get back if this has been validated on sc7280 without any concerns.
One question i had is not directly related to this series but related to multi-DP in general. Does audio work fine across both the DPs when both are connected?
The reason I ask this question is that, I dont know how two hdmi-codec instances are handled today. So we will register twice with hdmi-codec so there should be two audio streams.
But I am not sure if this works correctly in todays design with hdmi-codec.
Any chance you had validated this?
> > Bjorn Andersson (5): > drm/msm/dp: Remove global g_dp_display variable > drm/msm/dp: Modify prototype of encoder based API > drm/msm/dp: Support up to 3 DP controllers > dt-bindings: msm/dp: Add SC8180x compatibles > drm/msm/dp: Add sc8180x DP controllers > > .../bindings/display/msm/dp-controller.yaml | 2 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 60 +++--- > .../gpu/drm/msm/disp/msm_disp_snapshot_util.c | 8 +- > drivers/gpu/drm/msm/dp/dp_display.c | 183 +++++++++++++----- > drivers/gpu/drm/msm/msm_drv.h | 33 ++-- > 6 files changed, 200 insertions(+), 103 deletions(-)
|  |