Messages in this thread |  | | Subject | Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support | From | Akhil P Oommen <> | Date | Fri, 30 Jul 2021 00:27:23 +0530 |
| |
On 7/29/2021 10:46 PM, Stephen Boyd wrote: > Quoting Akhil P Oommen (2021-07-28 00:17:45) >> On 7/27/2021 5:46 AM, Stephen Boyd wrote: >>> Quoting Akhil P Oommen (2021-07-24 10:29:00) >>>> Add the necessary dt nodes for gpu support in sc7280. >>>> >>>> Signed-off-by: Akhil P Oommen <akhilpo@codeaurora.org> >>>> --- >>>> This patch has dependency on the GPUCC bindings patch here: >>>> https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-tdas@codeaurora.org/ >>> >>> To avoid the dependency the plain numbers can be used. >> >> But, won't that reduce readability and make things prone to error? > > The numbers are not supposed to change so maybe it reduces readability > but I don't see how it is prone to error.
I cross check GPU's clock list whenever there is a system level issue like NoC errors. So it is convenient to have the clock names here, at least for me. But, I will budge if it is not easy to manage the dependency.
> >> If >> the other patch doesn't get picked up soon, we should try this option. >> We like to get this patch merged in v5.15. > > The clk binding is already picked up but Bjorn would need to merge it > into the qcom tree to use it. I don't know what the plan is there. >
Bjorn, could you please advise here?
-Akhil.
|  |