lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] perf env: Normalize aarch64.* and arm64.* to arm64 in normalize_arch()
From
Date


On 26/07/2021 13:38, Li Huafei wrote:
> On my aarch64 big endian machine, the perf annotate does not work.
>
> # perf annotate
> Percent | Source code & Disassembly of [kernel.kallsyms] for cycles (253 samples, percent: local period)
> --------------------------------------------------------------------------------------------------------------
> Percent | Source code & Disassembly of [kernel.kallsyms] for cycles (1 samples, percent: local period)
> ------------------------------------------------------------------------------------------------------------
> Percent | Source code & Disassembly of [kernel.kallsyms] for cycles (47 samples, percent: local period)
> -------------------------------------------------------------------------------------------------------------
> ...
>
> This is because the arch_find() function uses the normalized architecture
> name provided by normalize_arch(), and my machine's architecture name
> aarch64_be is not normalized to arm64. Like other architectures such as
> arm and powerpc, we can fuzzy match the architecture names associated with
> aarch64.* and normalize them.
>
> It seems that there is also arm64_be architecture name, which we also
> normalize to arm64.
>
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
> ---
> Changes in v2:
> - The error log added in symbol__annotate() is put into a single patch
> - Remove the "Fixes" tag
> - According to James' suggestion, "arm64_be" is also normalized to
> "arm64"
>
> tools/perf/util/env.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
> index cec2e6cad8aa..ab341050be46 100644
> --- a/tools/perf/util/env.c
> +++ b/tools/perf/util/env.c
> @@ -349,7 +349,7 @@ static const char *normalize_arch(char *arch)
> return "x86";
> if (!strcmp(arch, "sun4u") || !strncmp(arch, "sparc", 5))
> return "sparc";
> - if (!strcmp(arch, "aarch64") || !strcmp(arch, "arm64"))
> + if (!strncmp(arch, "aarch64", 7) || !strncmp(arch, "arm64", 5))
> return "arm64";
> if (!strncmp(arch, "arm", 3) || !strcmp(arch, "sa110"))
> return "arm";
>

Reviewed-by: James Clark <james.clark@arm.com>

\
 
 \ /
  Last update: 2021-07-26 17:19    [W:0.038 / U:1.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site