Messages in this thread |  | | Subject | Re: [PATCH] watchdog: iTCO_wdt: Fix detection of SMI-off case | From | Guenter Roeck <> | Date | Mon, 26 Jul 2021 06:59:30 -0700 |
| |
On 7/26/21 6:40 AM, Andy Shevchenko wrote: > On Mon, Jul 26, 2021 at 3:04 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: >> >> On 26.07.21 14:01, Andy Shevchenko wrote: >>> On Mon, Jul 26, 2021 at 2:46 PM Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> >>>> From: Jan Kiszka <jan.kiszka@siemens.com> >>>> >>>> Obviously, the test needs to run against the register content, not its >>>> address. >>>> >>>> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout") >>>> Reported-by: Mantas Mikulėnas <grawity@gmail.com> >>> >>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >>> >>> Missed SoB of the submitter (hint: configure your Git to make sure >>> that submitter and author are the same in terms of name-email). >> >> The signed off is there. Not sure what you are referring to. > > Nope. It's not. The sign of that is the From: line in the body of the > email. It happens when the submitter != author. And SoB of the former > one is absent. But what is strange is that reading them here I haven't > found the difference. Maybe one is in UTF-8 while the other is not and > a unicode character degraded to Latin-1 or so? >
I have no idea why there is an additional From:, but both From: tags in the e-mail source are exact matches, and both match the name and e-mail address in Signed-off-by:. I agree with Jan, the SoB is there.
Guenter
|  |