Messages in this thread |  | | Subject | Re: [PATCH v2 2/2] printk: Add printk.console_verbose boot parameter | From | Dmitry Safonov <> | Date | Mon, 26 Jul 2021 14:37:49 +0100 |
| |
On 7/21/21 3:46 PM, Petr Mladek wrote: [..] >> + printk.console_verbose= >> + Raise console loglevel to highest on oops, panic or >> + lockdep-detected issues (only if lock debug is on). >> + With an exception to setups with low baudrate on >> + serial console, keeping this enabled is a good choice >> + in order to provide more debug information. >> + Format: <bool> (1/Y/y=enable, 0/N/n=disable) >> + default: enabled > > Hmm, the name suggests that the console should always be verbose. > It looks like a counterpart to the "quiet" option. > > It actually is a counter part to the existing "quiet" option > except that it triggers in some situations only. > > Hence, I would call it "no_auto_verbose": > > + "verbose" follows the simple naming scheme of the existing > "quiet" option (no "printk" and no "console" in the name) > > + "no_auto" suggests that it disables some auto-verbose behavior > which is exactly what it does. > > Any better idea?
Yeah, ok. I've tried to avoid negative as a parameter as it sometimes may be confusing. But I see you have this naming in mind and no hard feelings from my side - I'll call it "no_auto_verbose" in v3.
[..] >> @@ -2404,6 +2404,12 @@ module_param_named(console_suspend, console_suspend_enabled, >> MODULE_PARM_DESC(console_suspend, "suspend console during suspend" >> " and hibernate operations"); >> >> +bool printk_console_verbose = true; > > I would call it "console_auto_verbose". > >> +EXPORT_SYMBOL(printk_console_verbose); > > I would prefer to move console_verbose() into printk.c > and export the function instead of this variable.
Makes sense, will do in v3.
Thanks, Dmitry
|  |